From ded350e675217ca0c8669eb16ff6dea9e230d586 Mon Sep 17 00:00:00 2001 From: Timothy Farrell Date: Sat, 16 Dec 2017 04:58:51 -0600 Subject: [PATCH] Properly cleanup an image when it is removed --- .../src/interface/components/attachmentImage.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/gallery/src/interface/components/attachmentImage.js b/packages/gallery/src/interface/components/attachmentImage.js index 6f52675..87f13c6 100644 --- a/packages/gallery/src/interface/components/attachmentImage.js +++ b/packages/gallery/src/interface/components/attachmentImage.js @@ -31,11 +31,11 @@ async function loadImageFromBlob(doc, evt, node, vm) { } } -function cleanup(id, evt) { - const { src } = evt.target; +function cleanup(node) { + const src = node.el.src; if (src.startsWith('blob:')) { - URL.revokeObjectURL(s); - srcMap.remove(id); + URL.revokeObjectURL(src); + srcMap.delete(node.key); } } @@ -50,7 +50,7 @@ export function AttachmentImageView(doc, props) { onerror: [loadImageFromBlob, doc], _key: _id, _hooks: { - didRemove: [cleanup, _id] + willRemove: cleanup } }, props || {}