From c51e21a242522d76b3d0c2de26cd101ece1849b2 Mon Sep 17 00:00:00 2001
From: alleria173 <alleria173@proton.me>
Date: Fri, 3 Jul 2026 11:23:06 +0100
Subject: [PATCH] fix/2444 TOTP input validation for correct otpauth uri
 generation (#2621)

---
 src/core/operations/GenerateTOTP.mjs | 16 ++++--
 tests/operations/tests/OTP.mjs       | 77 ++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 4 deletions(-)

diff --git a/src/core/operations/GenerateTOTP.mjs b/src/core/operations/GenerateTOTP.mjs
index 187f8418..b6ce8698 100644
--- a/src/core/operations/GenerateTOTP.mjs
+++ b/src/core/operations/GenerateTOTP.mjs
@@ -26,22 +26,30 @@ class GenerateTOTP extends Operation {
             {
                 "name": "Name",
                 "type": "string",
-                "value": ""
+                "value": "Account",
+                "allowEmpty": false
             },
             {
                 "name": "Code length",
                 "type": "number",
-                "value": 6
+                "value": 6,
+                "min": 6,
+                "max": 8,
+                "integer": true
             },
             {
                 "name": "Epoch offset (T0)",
                 "type": "number",
-                "value": 0
+                "value": 0,
+                "min": 0,
+                "integer": true
             },
             {
                 "name": "Interval (T1)",
                 "type": "number",
-                "value": 30
+                "value": 30,
+                "min": 1,
+                "integer": true
             }
         ];
     }
diff --git a/tests/operations/tests/OTP.mjs b/tests/operations/tests/OTP.mjs
index 59ca9fec..9d67395e 100644
--- a/tests/operations/tests/OTP.mjs
+++ b/tests/operations/tests/OTP.mjs
@@ -86,4 +86,81 @@ TestRegister.addTests([
             },
         ],
     },
+    {
+        name: "Generate TOTP",
+        input: "JBSWY3DPEHPK3PXP",
+        expectedMatch: /^URI: otpauth:\/\/totp\/Account\?secret=JBSWY3DPEHPK3PXP&algorithm=SHA1&digits=6&period=30\n\nPassword: \d{6}$/,
+        recipeConfig: [
+            {
+                op: "Generate TOTP",
+                args: ["Account", 6, 0, 30], // [Name, Code length, Epoch offset (T0), Interval (T1)]
+            },
+        ],
+    },
+    {
+        name: "Generate TOTP - empty name rejected",
+        input: "JBSWY3DPEHPK3PXP",
+        expectedOutput: "Name cannot be empty.",
+        recipeConfig: [
+            {
+                op: "Generate TOTP",
+                args: ["", 6, 0, 30],
+            },
+        ],
+    },
+    {
+        name: "Generate TOTP - code length below minimum rejected",
+        input: "JBSWY3DPEHPK3PXP",
+        expectedOutput: "Code length must be greater than or equal to 6.",
+        recipeConfig: [
+            {
+                op: "Generate TOTP",
+                args: ["Account", -6, 0, 30],
+            },
+        ],
+    },
+    {
+        name: "Generate TOTP - code length above maximum rejected",
+        input: "JBSWY3DPEHPK3PXP",
+        expectedOutput: "Code length must be less than or equal to 8.",
+        recipeConfig: [
+            {
+                op: "Generate TOTP",
+                args: ["Account", 9, 0, 30],
+            },
+        ],
+    },
+    {
+        name: "Generate TOTP - non-integer code length rejected",
+        input: "JBSWY3DPEHPK3PXP",
+        expectedOutput: "Code length must be an integer.",
+        recipeConfig: [
+            {
+                op: "Generate TOTP",
+                args: ["Account", 6.5, 0, 30],
+            },
+        ],
+    },
+    {
+        name: "Generate TOTP - negative interval rejected",
+        input: "JBSWY3DPEHPK3PXP",
+        expectedOutput: "Interval (T1) must be greater than or equal to 1.",
+        recipeConfig: [
+            {
+                op: "Generate TOTP",
+                args: ["Account", 6, 0, -1],
+            },
+        ],
+    },
+    {
+        name: "Generate TOTP - negative epoch offset rejected",
+        input: "JBSWY3DPEHPK3PXP",
+        expectedOutput: "Epoch offset (T0) must be greater than or equal to 0.",
+        recipeConfig: [
+            {
+                op: "Generate TOTP",
+                args: ["Account", 6, -1, 30],
+            },
+        ],
+    },
 ]);