From 2a5b1deb2ed438507057dbb15794781a5108ccb6 Mon Sep 17 00:00:00 2001 From: Jacob Marks <100745682+J8k3@users.noreply.github.com> Date: Sat, 16 May 2026 23:04:55 -0400 Subject: [PATCH] Add Payment Operation Maintenance rules to AGENTS.md --- AGENTS.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 224ee21c..6513f92a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -15,8 +15,7 @@ ## Session Start - At the start of a session, sync with `origin/master` before doing substantive work. -- Preferred command: - - `git pull --rebase origin master` +- Preferred command: `git pull --rebase origin master` - Only do this automatically when the worktree is clean. - If there are local changes already present, do not pull/rebase blindly; inspect first and avoid overwriting user work. @@ -28,6 +27,15 @@ - Split work before committing when a reviewer would benefit from evaluating the pieces independently. - Only keep changes together when separating them would make the behavior harder to understand, test, or revert. +## Payment Operation Maintenance + +When adding, renaming, or removing a payment operation: + +1. **Update `PAYMENT_RECIPES.md`** — add the operation to the correct numbered section and, if it introduces a new chaining pattern, add a lettered chaining pattern entry. Remove or mark deprecated any operations that are replaced. +2. **Follow the naming convention** — all payment operation display names use Title Case. Acronyms (DUKPT, AES, EMV, MAC, PAN, TR-31, TR-34, KCV) stay upper-case. Brand names keep their canonical form (`payShield`). Pattern: `[Verb] [Optional Qualifier] [Noun]`. See the Naming Convention section in `PAYMENT_RECIPES.md`. +3. **Keep `this.name` and file name consistent** — the CyberChef UI shows `this.name`; the file name is the class name in PascalCase. Both should reflect the same intent. +4. **Do not rename `this.name` without updating `PAYMENT_RECIPES.md`** — stale names in the doc are confusing and break recipe search. + ## Current Project Preference - For this fork, validate payment-related changes through the Docker-based workflow before judging safety to commit.