exlim/cyberchef
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix BigNumber deserialisation in Dish, and add tests (#2607)

Browse Source 
With ideas from: cyphercodes <cyphercodes@users.noreply.github.com>
With ideas from: Sivachandran Paramasivam <sivachandran.p@gmail.com>
This commit is contained in:
GCHQDeveloper581 2026-06-26 13:07:33 +01:00 committed by GitHub
parent 2329a0a0e5
commit 275b594f7c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 55 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/Dish.mjs
View File

@ -292,11 +292,7 @@ class Dish {
and reinitialise it as a BigNumber object.
*/
if (Object.keys(this.value).sort().equals(["c", "e", "s"])) {
const temp = new BigNumber();
temp.c = this.value.c;
temp.e = this.value.e;
temp.s = this.value.s;
this.value = temp;
this.value = new BigNumber({ s: this.value.s, e: this.value.e, c: this.value.c, _isBigNumber: true});
return true;
}
return false;

4
tests/browser/02_ops.js
View File

@ -346,8 +346,8 @@ module.exports = {
// testOp(browser, "Strip HTTP headers", "test input", "test_output");
// testOp(browser, "Subsection", "test input", "test_output");
// testOp(browser, "Substitute", "test input", "test_output");
// testOp(browser, "Subtract", "test input", "test_output");
// testOp(browser, "Sum", "test input", "test_output");
testOp(browser, "Subtract", "321,123,test", "198", ["Comma"]);
testOp(browser, "Sum", "321,123,test", "444", ["Comma"]);
// testOp(browser, "Swap endianness", "test input", "test_output");
// testOp(browser, "Symmetric Difference", "test input", "test_output");
testOpHtml(browser, "Syntax highlighter", "var a = [4,5,6]", ".hljs-selector-attr", "[4,5,6]");

19
tests/node/tests/Dish.mjs
View File

@ -9,4 +9,23 @@ TestRegister.addApiTests([
assert(dish.presentAs);
}),
it("Disk - should not error on serialized BigNumber (0)", () => {
const dish = new Dish({ s: 1, e: 0, c: [0] }, Dish.BIG_NUMBER);
assert.strictEqual(dish.value.toString(), "0");
}),
it("Dish - should not error on serialized BigNumber (1)", () => {
const dish = new Dish({ c: [1], e: 0, s: 1 }, Dish.BIG_NUMBER);
assert.strictEqual(dish.value.toString(), "1");
}),
it("Dish - should not error on serialized BigNumber (-100)", () => {
const dish = new Dish({ s: -1, e: 2, c: [100] }, Dish.BIG_NUMBER);
assert.strictEqual(dish.value.toString(), "-100");
}),
it("Dish - should not error on serialized BigNumber (NaN)", () => {
const dish = new Dish({ s: null, e: null, c: null }, Dish.BIG_NUMBER);
assert.strictEqual(dish.value.toString(), "NaN");
}),
]);

33
tests/operations/tests/Arithmetic.mjs Normal file
View File

@ -0,0 +1,33 @@
/**
* Tests for arithmetical operations
*
* @copyright Crown Copyright 2026
* @license Apache-2.0
*/
import TestRegister from "../../lib/TestRegister.mjs";
TestRegister.addTests([
{
name: "Subtract",
input: "321,123,test",
expectedOutput: "198",
recipeConfig: [
{
"op": "Subtract",
"args": ["Comma"]
},
],
},
{
name: "Subtract - no valid input",
input: "test",
expectedOutput: "NaN",
recipeConfig: [
{
"op": "Subtract",
"args": ["Comma"]
},
],
},
]);